Bump plantuml and xwiki-contrib/parent-platform dependencies and fix TODOs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunklecat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
I've stumbled upon this repository while I was using xWiki as I needed a way to embed a pair of plantuml diagrams inside a page. I tried to minimize the edits as I only wanted to update PlantUML and the xwiki-contrib/parent-platform deps. As I dig a little inside the code I found some TODO's about problems that should be fixed by now afaik.
I admit I didn't fully tested the edits apart from what I needed and mvn test.
Let me know if there's something that I missed. Keep up the good work!